This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Remove sys_ptrace dependency #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <[email protected]>
|
Thank you for opening this pull request! 🙌 |
pingsutw
changed the title
Signed-off-by: Kevin Su <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #36 +/- ##
=======================================
Coverage 17.79% 17.79%
=======================================
Files 3 3
Lines 399 399
=======================================
Hits 71 71
Misses 315 315
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kevin Su [email protected]
TL;DR
Remove shared process watcher, and use file watcher by default.
Type
Are all requirements met?
Complete description
Stop
exitWatcherif an empty file namedSUCCESSisn't present after some amount of time.Tracking Issue
flyteorg/flyte#2162
Follow-up issue
NA